-
Notifications
You must be signed in to change notification settings - Fork 680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a timeout for downloading razor telemetry #6622
Add a timeout for downloading razor telemetry #6622
Conversation
'.razortelemetry', | ||
'Microsoft.VisualStudio.DevKit.Razor.dll' | ||
); | ||
if (await util.fileExists(telemetryExtensionPath)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved this all out just because of the await
Boy this UI stuff is easier in VS Code than in VS 😛 |
this.eventStream.post(new InstallationSuccess()); | ||
return true; | ||
} | ||
await vscode.window.withProgress( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Who wrote that annoying razor formatting test anyway.... |
Fixes #6547
The issue these users are having is to do with their proxy settings in VS Code, and is happening inside where we already have error handling for the download, so it seems like node is just stuck downloading. The only recourse I could work out was a timeout, so at least we're not blocking users forever.